Wait for certificate before starting HTTP listener #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 25, 2022 12:03
When starting up, the HTTP server can start accepting requests before the TLS config has loaded certificates from the certificate generator. We add in a wait (assuming we don't have certificates already given to us via flags or environment variables) for that certificate to be generated before starting the server to prevent confusing, though harmless, errors in logs. * Fixes #318 * Fixes #320
swenson
force-pushed
the
vault-5084/wait-for-cert-issue-before-starting
branch
from
b6485fe to
bd359ee
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting up, the HTTP server can start accepting requests before
the TLS config has loaded certificates from the certificate generator.
We add in a wait (assuming we don't have certificates already given to
us via flags or environment variables) for that certificate to be
generated before starting the server to prevent confusing, though
harmless, errors in logs.