Wait for handler startup until TLS has been established #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a Mutex before starting the handler and if certificate has not been updated yet: unlock the mutex. Simple solution without over usage of channels. Kept in function scope to prevent clutter and keep the ownership locally.
Check the TLS minimum version and cipher suites before waiting for certificates to be loaded in. This prevents longer startup times when misconfigured.
Add the flag server-wait-for-tls-cert to be able to toggle the behaviour of waiting for the TLS to be updated before starting HTTP server.
Change split_words to envconfig to maintain the _tls_ instead of t_l_s
Add AGENT_INJECT_SERVER_WAIT_FOR_TLS_CERT environment variable with default to true
|
Back in draft to migrate sync.Cond to semaphore.Weighted alternative |
Rather than using a condition decided to use a semaphore. Mutexes aren't ment for wait-conditions, yet the calls made are less than with a semaphore. Decided to neglect that and go with semaphores.
|
|
|
Thanks for the patch here, though we decided to go with a channel-based approach in #354. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the logic needed for toggle-able server wait. This prevents errors from any requests being sent to the HTTP server, most notably the kubelet or the kube-api.
Linked issue(s)
#320