Move the volumeMounts section back to the right position again. #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit: d27121 Added webhook-certs volume mount to sidecar injector (#545) had it fixed correctly in the past. But by the short-term decision to take the leader elector container out then back in has "probably" led to this circumstance during copy&paste that the volumemount has moved down again. see changes how it came to this small error. remove leader-elector: d31f94 Support vault-k8s internal leader election (#568) bring leader-elector back: 5a864f Adding support for the old leader-elector (#607)
|
|
|
Thanks for spotting this and for the patch, though if webhook certs are specified, then the leader elector container shouldn't be enabled anyway. Also for the next release we're planning to remove the leader-elector container deployment again. |
|
Closing for now, since the leader-elector container was removed from the deployment in 0.18.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit:
d27121 Added webhook-certs volume mount to sidecar injector (#545)
had it fixed correctly in the past.
But by the short-term decision to take the leader elector container out then back in has "probably" led to this circumstance during copy&paste that the volumemount has moved down again.
see changes how it came to this small error.
remove leader-elector: d31f94 Support vault-k8s internal leader election (#568)
bring leader-elector back: 5a864f Adding support for the old leader-elector (#607)