Support vault-k8s internal leader election #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check configmap ownerref for leadership.
tomhjp
approved these changes
Aug 31, 2021
benashz
reviewed
Aug 31, 2021
| owner=$(kubectl get configmaps vault-k8s-leader -o json | jq -r .metadata.ownerReferences\[0\].name) | ||
| leader=$(kubectl get pods $owner -o json | jq -r .metadata.name) | ||
| [ -n "${leader}" ] && [ "${leader}" != "null" ] && break | ||
| let "tries=tries+1" |
There was a problem hiding this comment.
You prefer to use let instead of the ++ operator?
There was a problem hiding this comment.
I prefer whatever works, and this works 😄
There was a problem hiding this comment.
(To explain more, ((tries++)) seems to always throw an error for me under bats.)
benashz
approved these changes
Aug 31, 2021
tvoran
added a commit
that referenced
this pull request
Sep 3, 2021
Adds the leader-elector container support that was removed in PR #568. The new vault-k8s uses an internal mechanism for leader determination, so this is just for backwards compatibility, and can be removed in the near future.
tvoran
added a commit
that referenced
this pull request
Sep 16, 2021
Adds the leader-elector container support that was removed in PR #568. The new vault-k8s uses an internal mechanism for leader determination, so this is just for backwards compatibility, and can be removed in the near future. * mark the endpoint as deprecated * add a new useContainer option for leaderElector Default to not deploying the old leader-elector container, unless injector.leaderElector.useContainer is `true`.
This was referenced Oct 27, 2021
illegalnumbers
pushed a commit
to streamnative/vault-helm
that referenced
this pull request
Mar 17, 2022
illegalnumbers
pushed a commit
to streamnative/vault-helm
that referenced
this pull request
Mar 17, 2022
Adds the leader-elector container support that was removed in PR hashicorp#568. The new vault-k8s uses an internal mechanism for leader determination, so this is just for backwards compatibility, and can be removed in the near future. * mark the endpoint as deprecated * add a new useContainer option for leaderElector Default to not deploying the old leader-elector container, unless injector.leaderElector.useContainer is `true`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds extra RBAC and removes leader-elector container deployment to support hashicorp/vault-k8s#271.