Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go-tfe, fix panic for certain kinds of state create errors #34074

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

brandonc
Copy link
Contributor

When state version creation fails in terraform 1.6 (for instance, due to staleness), go-tfe was neglecting to return that error and crashing terraform with a nil pointer dereference panic. (See hashicorp/go-tfe#791)

Target Release

1.6.2

Draft CHANGELOG entry

BUG FIXES

cloud: Fixes panic when saving state after Terraform Cloud returns certain types of API errors

Simulating state conflict

Terraform 1.6.1

Screenshot 2023-10-12 at 11 00 18 AM

With this change

Screenshot 2023-10-12 at 11 01 01 AM

@brandonc brandonc merged commit f44733a into v1.6 Oct 12, 2023
@brandonc brandonc deleted the brandonc/bump_go-tfe_1.36.0 branch October 12, 2023 22:35
@github-actions
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link
Contributor

github-actions bot commented Dec 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants