panic: runtime error in stateVersions.Upload

[LukasHeimann]

go-tfe version

1.34.0

Embedded in Terraform 1.6.1

Description

When I ran terraform apply, terraform dumped with a stacktrace pointing to go-tfe:

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x11e9936]

goroutine 1150 [running]:
github.com/hashicorp/go-tfe.(*stateVersions).Upload.func1()
	/home/runner/go/pkg/mod/github.com/hashicorp/[email protected]/state_version.go:294 +0xb6
golang.org/x/sync/errgroup.(*Group).Go.func1()
	/home/runner/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x56
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 39
	/home/runner/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96

(see https://github.com/golang/sync/blob/v0.3.0/errgroup/errgroup.go#L75 and https://github.com/hashicorp/go-tfe/blob/v1.34.0/state_version.go#L294)

While the log shows the issue in a situation with unchanged infrastructure, this also happens when changes were applied successfully. However, the updated state was not persisted, as I was able to validate with a subsequent terraform plan.

This may or may not be related to the remote backend I am using. In the past, it also sometimes had problems where fields were missing, causing problems with newer versions of go-tfe (via newer versions of terraform).

In any case, I'd have expected a good exception instead of a segfault, which also leaves the terraform state locked instead of failing more gracefully.

The problem happens both in a ci system (linux) as well as on a developer machine (windows 11).

Thank you very much for your support!

Testing plan

?

Expected Behavior

go-tfe should not crash

Actual Behavior

go-tfe crashed with a segfault

Additional Context

[brandonc]

Hey, thanks for this report. I definitely see an issue with attempting to upload a state version after it failed to be created (If Line 287 evaluates to false)

Are you running against Terraform Enterprise? I wonder if you could give me some some details about which version
that is.

[ToniA]

I think this is the same issue I have with JFrog Artifactory backend store. Terraform versions up to 1.5.7 work fine.

[brandonc]

This fix will be released in Terraform 1.6.2

[LukasHeimann]

I assume it will still not work with Artifactory as a backend, because the error is explicitly triggered due to Artifactories "not implemented" error message having a different string value then (older) Terraform Enterprise messages, though -- it just will fail more gracefully.