Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include field descriptions when generating resources with tpgtools #9197

Closed
melinath opened this issue May 19, 2021 · 1 comment · Fixed by GoogleCloudPlatform/magic-modules#5165, hashicorp/terraform-provider-google-beta#3597 or #10022
Assignees
Labels
enhancement size/s tpgtools Issues related to the tpgtools generator

Comments

@melinath
Copy link
Collaborator

melinath commented May 19, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Tpgtools currently doesn't include field descriptions when generating resources. There is a note:

Description: `{{/* TODO fix formatting for $p.Description */}}

which seems to indicate that this is more complicated than just printing the value there. We should include the description value to be complete, even though it's not generally displayed to users.

@github-actions
Copy link

github-actions bot commented Oct 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.