-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tpgtools spit out working documentation. #5165
Conversation
Another oom issue in TeamCity. This diff is all just description stuff, am I okay to merge without running those tests or do I need to wait for them? |
Ah, might as well just go again. /gcbrun |
I'd just go for it, the only danger here would be non-compiling resources but that would show up real quickly! |
Will do, thanks. The test as it stands seems to prove that it does compile at least! |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeOrganizationSecurityPolicyAssociation_organizationSecurityPolicyAssociationBasicExample|TestAccFirebaseWebApp_firebaseWebAppBasicExample|TestAccTags You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=204729 |
Tests failed during RECORDING mode: TestAccFirebaseWebApp_firebaseWebAppBasicExample|TestAccComputeOrganizationSecurityPolicyAssociation_organizationSecurityPolicyAssociationBasicExample Please fix these to complete your PR |
* Make tpgtools spit out working documentation. * Fix typo. typo is also present in dcl config, will fix that separately.
In order for KCC to depend on a tpgtools resource, tpgtools needs to fix the longstanding-but-low-priority bug with documentation escaping. It turns out not to be too hard since go doesn't have a whole lot of necessary escape sequences - just
"
,\
, and newlines. Made it a function that's easy to work with if we find more that we need to add, although I was going based on https://golang.org/ref/spec#String_literals so it should be pretty correct.Fixes hashicorp/terraform-provider-google#9197.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)