Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagged relevant issue in the todo #4801

Merged

Conversation

melinath
Copy link
Member

I made hashicorp/terraform-provider-google#9197 to track this TODO. This PR adds a link to the issue so that we don't lose track of the issue in the future.


@google-cla google-cla bot added the cla: yes label May 19, 2021
@melinath melinath requested review from a team and rileykarson and removed request for a team May 19, 2021 22:49
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=188276"

@melinath melinath merged commit 013efdb into GoogleCloudPlatform:master May 19, 2021
@melinath melinath deleted the tpg-9197-tag-issue-on-todo branch May 19, 2021 23:12
@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=188400"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants