Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_scheduler_schedule - correct assign_public_ip description #29659

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

bennylu2
Copy link
Contributor

Description

Terraform code converts bool into ENABLED or DISABLED for assign_public_ip

if v, ok := tfMap["assign_public_ip"].(bool); ok {
if v {
awsvpcConfig.AssignPublicIp = types.AssignPublicIpEnabled
} else {
awsvpcConfig.AssignPublicIp = types.AssignPublicIpDisabled
}
}

Description looks like it was copied from docs as-is, updating to correct bool

Relations

Closes #29464

References

https://docs.aws.amazon.com/scheduler/latest/APIReference/API_CreateSchedule.html
https://docs.aws.amazon.com/scheduler/latest/APIReference/API_AwsVpcConfiguration.html

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/scheduler Issues and PRs that pertain to the scheduler service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Feb 25, 2023
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Mar 10, 2023
@jar-b jar-b merged commit 0dfffaf into hashicorp:main Mar 10, 2023
@github-actions github-actions bot added this to the v4.59.0 milestone Mar 10, 2023
@jar-b
Copy link
Member

jar-b commented Mar 10, 2023

Thanks for your contribution, @bennylu2! 👏

@github-actions
Copy link

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/scheduler Issues and PRs that pertain to the scheduler service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: EventBridge Scheduler incorrect assign_public_ip documentation
2 participants