Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: EventBridge Scheduler incorrect assign_public_ip documentation #29464

Closed
ghost opened this issue Feb 17, 2023 · 3 comments · Fixed by #29659
Closed

[Docs]: EventBridge Scheduler incorrect assign_public_ip documentation #29464

ghost opened this issue Feb 17, 2023 · 3 comments · Fixed by #29659
Labels
documentation Introduces or discusses updates to documentation. service/scheduler Issues and PRs that pertain to the scheduler service.
Milestone

Comments

@ghost
Copy link

ghost commented Feb 17, 2023

Documentation Link

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/scheduler_schedule

Description

The documentation referring to assign_public_ip which belongs in the network_configuration block, which belongs in the ecs_parameters block, which belongs in the target block, is incorrect.

The documentation says:

assign_public_ip - (Optional) Specifies whether the task's elastic network interface receives a public IP address. You can specify ENABLED only when the launch_type is set to FARGATE. One of: ENABLED, DISABLED.

but if you run it using something like assign_public_ip = "DISABLED" you will be greeded with a Terraform validation error that says:

Error: Incorrect attribute value type
on scheduler.tf line 24, in resource "aws_scheduler_schedule" "ecs_task_schedule":
24: assign_public_ip = "DISABLED"
Inappropriate value for attribute "assign_public_ip": a bool is required.

so clearly the correct value (validated by terraform validate) should be assign_public_ip = false

FURTHERMORE. The documentation for this resource type is EXTREMELY lacking. There are absolutely NO examples covering how one might use this to trigger an ECS task.

References

No response

Would you like to implement a fix?

None

@ghost ghost added documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. labels Feb 17, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/scheduler Issues and PRs that pertain to the scheduler service. label Feb 17, 2023
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Mar 10, 2023
@github-actions github-actions bot added this to the v4.59.0 milestone Mar 10, 2023
@github-actions
Copy link

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/scheduler Issues and PRs that pertain to the scheduler service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants