-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance FIPS, DualStack, IMDS Endpoint Support #22804
Conversation
22b5c80
to
4623d65
Compare
Also need to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEC2Instance_basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2Instance_basic -timeout 180m
=== RUN TestAccEC2Instance_basic
=== PAUSE TestAccEC2Instance_basic
=== CONT TestAccEC2Instance_basic
--- PASS: TestAccEC2Instance_basic (117.74s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 121.414s
% AWS_USE_FIPS_ENDPOINT=true make testacc TESTARGS='-run=TestAccEC2Instance_basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2Instance_basic -timeout 180m
=== RUN TestAccEC2Instance_basic
=== PAUSE TestAccEC2Instance_basic
=== CONT TestAccEC2Instance_basic
--- PASS: TestAccEC2Instance_basic (130.23s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 133.764s
This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #20824
Requires hashicorp/aws-sdk-go-base#88
Relates aws/aws-sdk-go#3938
Running a similar config to #20824:
The current provider throws the error shown in #20824. However, with a provider built from this branch, this is the result (the correct result since it creates no resources):
Output from acceptance testing (randomly chosen to make sure things work as normal):