Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate support for AWS_METADATA_URL in favour of official AWS_EC2_METADATA_SERVICE_ENDPOINT #22825

Closed
gdavison opened this issue Jan 28, 2022 · 3 comments · Fixed by #22998
Closed

Deprecate support for AWS_METADATA_URL in favour of official AWS_EC2_METADATA_SERVICE_ENDPOINT #22825

gdavison opened this issue Jan 28, 2022 · 3 comments · Fixed by #22998
Assignees
@YakDriver
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope.
Milestone
v4.0.0

Comments

@gdavison
Copy link
Contributor

Historically, aws-sdk-go-base supported the non-standard environment variable AWS_METADATA_URL to override the EC2 Metadata Service endpoint. The AWS SDK for Go v2 has supported the official environment variable AWS_EC2_METADATA_SERVICE_ENDPOINT from the start, and the AWS SDK for Go v1 added support in v1.40.0.

Update provider documentation to indicate the deprecation of the old environment variable and usage of the new one.

Functional deprecationwill be handled by hashicorp/aws-sdk-go-base#89
@gdavison gdavison added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 28, 2022
@gdavison gdavison added this to the v4.0.0 milestone Jan 28, 2022
@gdavison gdavison added the documentation Introduces or discusses updates to documentation. label Jan 28, 2022
This was referenced Jan 28, 2022
Closed
Closed
@YakDriver
Copy link
Member

I picked up ec2_metadata_service_endpoint and ...mode in #22804

@YakDriver YakDriver self-assigned this Feb 7, 2022
@YakDriver YakDriver mentioned this issue Feb 7, 2022
Merged
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

Add metadata url, new arg docs hashicorp/terraform-provider-aws
2 participants
@gdavison @YakDriver