Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dot-local instead of dot-internal #17574

Merged
merged 1 commit into from
Feb 11, 2021
Merged

use dot-local instead of dot-internal #17574

merged 1 commit into from
Feb 11, 2021

Conversation

jrobison-sb
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

If you create the resources listed in these docs by copy/pasting, the .local domain works when Route53 is queried. But Ubuntu (and probably others) won't be able to resolve the hostname because Ubuntu (and probably others) treats .local as a special TLD and doesn't forward those queries to the VPC's DNS server. Using .internal works as expected.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

N/A, documentation only.

@jrobison-sb jrobison-sb requested a review from a team as a code owner February 11, 2021 20:28
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. labels Feb 11, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 11, 2021
@anGie44 anGie44 removed the needs-triage Waiting for first response or review from a maintainer. label Feb 11, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jrobison-sb 🚀 🚀 🚀

@anGie44 anGie44 added this to the v3.28.0 milestone Feb 11, 2021
@anGie44 anGie44 merged commit c5b5f3f into hashicorp:main Feb 11, 2021
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants