Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dot internal instead of dot local #15081

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Use dot internal instead of dot local #15081

merged 1 commit into from
Feb 11, 2021

Conversation

jrobison-sb
Copy link
Contributor

@jrobison-sb jrobison-sb commented Sep 9, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

If you create the resources listed in these docs by copy/pasting, the .local domain works when Route53 is queried. But Ubuntu (and probably others) won't be able to resolve the hostname because Ubuntu (and probably others) treats .local as a special TLD and doesn't forward those queries to the VPC's DNS server. Using .internal works as expected.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

N/A, documentation only.

@jrobison-sb jrobison-sb requested a review from a team September 9, 2020 00:02
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. needs-triage Waiting for first response or review from a maintainer. labels Sep 9, 2020
@breathingdust
Copy link
Member

LGTM 🚀 Thanks @jrobison-sb!

@breathingdust breathingdust merged commit bc48c21 into hashicorp:master Feb 11, 2021
@breathingdust
Copy link
Member

@jrobison-sb I just realized that this PR was targeted against master, rather than main. Not sure why this PR wasn't re-targeted when we made the switch, but if you create a new PR against main I can merge.

@jrobison-sb
Copy link
Contributor Author

@breathingdust Oh, I wasn't aware of the switch in branch names. Woops.

Have done so: #17574

@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants