Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TF-7737] Fix incorrect attribute type for RegistryModule.VCSRepo.Tags #789

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[TF-7737] Fix incorrect attribute type for RegistryModule.VCSRepo.Tags #789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
<!-- Add CHANGELOG entry to this section for any PR awaiting the next release -->
<!-- Please also include if this is a Bug Fix, Enhancement, or Feature -->

## Bug Fixes
* Fix incorrect attribute type for `RegistryModule.VCSRepo.Tags` by @hashimoon [#789](https://github.com/hashicorp/go-tfe/pull/789)

# v.1.35.0
## Features
* Added BETA support for private module registry tests by @hashimoon [#781](https://github.com/hashicorp/go-tfe/pull/781)
Expand Down
2 changes: 1 addition & 1 deletion registry_module.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ type RegistryModuleVCSRepoUpdateOptions struct {
// When a value for Tags is provided, the Branch field is removed on the server
// **Note: This field is still in BETA and subject to change.**
Branch *string `json:"branch,omitempty"`
Tags *string `json:"tags,omitempty"`
Tags *bool `json:"tags,omitempty"`
}

// List all the registory modules within an organization.
Expand Down
2 changes: 1 addition & 1 deletion registry_module_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ func TestRegistryModuleUpdateWithVCSConnection(t *testing.T) {

options = RegistryModuleUpdateOptions{
VCSRepo: &RegistryModuleVCSRepoUpdateOptions{
Tags: String("1.0.0"),
Tags: Bool(true),
},
}
rm, err = client.RegistryModules.Update(ctx, RegistryModuleID{
Expand Down