-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helper script to setup envvars via envchain #399
Conversation
625c0be
to
959dc89
Compare
If we like this script, I can update the testing docs to reference the script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider alternative solutions to envchain? A concern we have that this script is customized to a very specific tool and other may not end up using this script because everyone ends using their own alternative solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't hit approve cause I'm assuming you're going to address some changes requested by @uturunku1 (so it will dismiss my approval anyways) -- I like the idea of this script, thank you for this 👍
Once they're addressed, everything looks good to me ✅
959dc89
to
eacd88c
Compare
eacd88c
to
abf3c3d
Compare
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Description
Add a helper script to simplify setting env vars via envchain. Script prompts for an envchain workspace name, then invokes envchain with the environment variables.
Testing plan
./scripts/setup-test-envvars.sh
Output from tests (HashiCorp employees only)