✨ Add private registry provider, provider version, and provider platform APIs

[joekarl]

Description

This PR adds support for private registry provider APIs, which includes adding support for the following APIs:

• Private registry provider
• Private provider version
• Private provider platform

Testing plan

To test these changes locally, create a local go project, and in the go.mod include a line similar to the following:

replace github.com/hashicorp/go-tfe => /Users/YOURUSER/go/src/github.com/hashicorp/go-tfe

Then, you can test the following functionality:

• Registry provider: create, delete, read, list
• Registry provider version: create, delete, read, list
• Registry provider platform: create, delete, read, list

External links

• Private Provider Versions and Platforms API
• Registry Providers API
• Private Registry Provider Requirements
• GPG Keys API - this will be handled in a separate PR.

Output from tests (HashiCorp employees only)

$ TFE_ADDRESS="https://example" TFE_TOKEN="example" TF_ACC="1" go test ./... -v -tags=integration -run TestFunctionsAffectedByChange

...

[sebasslash]

All in all, everything looks awesome so far 🔥 ! Admittedly, I haven't given it a thorough review but a few 1.0 related things stuck out to me looking over your changes.

One thing I'll add is if you add any include params to a read or list option to make sure the valid relations that can be included live as string enums #294

[uturunku1]

Hey Karl!
I left two comments for you.
I am happy to see that your PR is following our go-tfe best practices so far.
Once your PR is no longer a draft and you are ready for a final review, I'd like to smoke test your changes. If you can leave in the PR description detailed instructions on how to smoke test for this feature, I'd greatly appreciate it!

[hashicorp-cla]

All committers have signed the CLA.

[daniel-laszlo]

Hi @joekarl , @sebasslash , @uturunku1

We are very much interested in publishing providers to private registry. Do I understand right that this MR is the missing piece for it?

[sebasslash]

Hi @daniel-laszlo ! Yes if your means is to use go-tfe, however in the meantime you can do so directly calling the private registry/provider API.

Once the go-tfe changes are released, we'll subsequently add support to the tfe provider.

[annawinkler]

I've been thinking about breaking this PR up into 3 separate PRs, and I think I'll do that.

[brandonc]

Submitting a partial review. I still need to review the tests. Looks great!

[sebasslash]

Looking great! Almost there across the finish line 🐎

[uturunku1]

@annawinkler Hey Anna! If you have any questions about my comments, let me know over slack (I occasionally miss pings over GitHub). Great job with all the testing done by the way!

[annawinkler]

A question was raised about these methods - should they be exported? I don't think they should be.

[annawinkler]

A question was raised about these methods - should they be exported? I don't think they should be.

Actually, we do want to export them. The idea is the workflow would be:

• Create a registry provider version
• Get the upload URLs from the newly-created registry provider version and use them to upload the shasums and shasums sig. Alternatively, could check the uploaded boolean values to see if the items have been uploaded, and if not upload them.
• Then later could use the download URLs to download the shasums and shasums sig.

[brandonc]

Very nice

[brandonc]

ah, yes, scrimbles64

[uturunku1]

Lol, I couldn't find the meaning of "scrimbles" in the dictionary, but this sounds funny 😆

[annawinkler]

It's a made up word from a former coworker from long ago that I still use 🥳

[sebasslash]

Woohooo @annawinkler and @joekarl !!! :celebration_dance

[github-actions]

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.