Fix enforce marshalling #209
Merged
+76
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarismail
commented
Apr 15, 2021
| defer policyCleanup1() | ||
| pTest2, policyCleanup2 := createUploadedPolicy(t, client, true, orgTest) | ||
| defer policyCleanup2() | ||
| wTest, wsCleanup := createWorkspace(t, client, orgTest) |
There was a problem hiding this comment.
Drive by changes to fix dangling resources problem
chrisarcand
approved these changes
Apr 15, 2021
chrisarcand
pushed a commit
that referenced
this pull request
Apr 20, 2021
This commit is for a separate backported release of the following fix, for the 0.13.x series of the client. In #197 we changed the type of Policy.Enforce from []*Enforcement to []Enforcement. This had downstream impact on the terraform-provider, which relies on this client (as well as any other 3rd parties that use this client!) This PR primarily reverts the type changes of Policy.Enforce back to being a []*Enforcement. It also updates the hashicorp/jsonapi package to reference the latest version. It also includes a field tag change necessary from #209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A previous PR #197 sought to use
jsonapifor all marshalling and unmarshalling of Resources. This went mostly well, but had a few breaking changes. It was discovered that some structs were not properly being marshaled. Those were fixed in #204 .This PR changes a few the tag for
EnforcementOptionsthat was altered in #197 back to usingjsontag. This is an interim step until the hashicorp/jsonapi package has the capability to handle nested structs.It also alters the
Enforceattribute to not use a slice of pointers because that is incompatabile with hashicorp/jsonapi, and just uses a slice of structs (which works with the jsonapi package).Output from tests
todo: print output from full test suite