fix marshalling for vcs repo options #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jsonapi library doesn't marshal model attributes that are structs properly if they use the jsonapi attr struct tag; let's use regular json struct tags for nested attributes
radditude
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The jsonapi library doesn't marshal model attributes that are structs properly if they use the jsonapi attr struct tag, but only when marshalling requests; when unmarshalling the response,
attrtags work just fine. In other words,WorkspacePermissionsare working fine since they're included in the response, but aren't something that's set in the request;VCSRepoOptionsare options for the request itself, so they're not working.Testing plan
External links
#202