This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Add component label to all services #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables querying specific services by labels. Without this label, most services in the chart have no distinguishing labels, making it difficult to target specific services with a label selector. This enables better integration with tools like prometheus-operator which use label selectors to determine which endpoints to monitor, as not all services need to be monitored, and some overlap and reference the same pods.
|
|
ishustava
added
area/chart-only
ishustava
approved these changes
Jun 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables querying specific services by labels.
Without this label, most services in the chart have no distinguishing
labels, making it difficult to target specific services with a label
selector.
This enables better integration with tools like prometheus-operator
which use label selectors to determine which endpoints to monitor, as
not all services need to be monitored, and some overlap and reference
the same pods.