Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Add component label to services #196

Closed
infa-bsurber opened this issue Jun 20, 2019 · 2 comments
Closed

Add component label to services #196

infa-bsurber opened this issue Jun 20, 2019 · 2 comments
Labels
area/chart-only Related to changes that simply require yaml chart changes, e.g. exposing a new field enhancement New feature or request size/small Small amount of work (<1 day)

Comments

@infa-bsurber
Copy link

I need some way to select between the UI and Server services based on their labels.
Currently these services have the same set of labels.

An easy fix seems to be adding a "component" label like the one in the deployed pods:
https://github.com/hashicorp/consul-helm/blob/master/templates/server-statefulset.yaml#L36
@lkysow lkysow added the enhancement New feature or request label Jun 25, 2019
@lkysow
Copy link
Member

lkysow commented Jun 25, 2019

That makes sense to me.

@lkysow lkysow added area/chart-only Related to changes that simply require yaml chart changes, e.g. exposing a new field size/small Small amount of work (<1 day) labels Sep 17, 2019
@lkysow
Copy link
Member

lkysow commented Jun 25, 2020

This was closed in #480!

@lkysow lkysow closed this as completed Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/chart-only Related to changes that simply require yaml chart changes, e.g. exposing a new field enhancement New feature or request size/small Small amount of work (<1 day)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lkysow @infa-bsurber