-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New main content header component #34
Conversation
title=(component 'rose/layout/main/header/title') | ||
)}} | ||
|
||
<div class="rose-layout-main-header-actions"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrapper div as providing a new class name through attributes isn't merged into button classname correctly.
Ref: emberjs/ember.js#17533
Updates: I was able to refactor previous use of dropdown title component, so I'd like to leave it as it is if non-detrimental. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ditch the dedicated page header layout stuff and build a page/content layout with four regions:
- header
- actions/utilities
- navigation
- main/body
<Rose::Layout::Page as |page|>
<page.header>
<h2>Title</h2>
</page.header>
<page.actions>
<button>stuff</button>
</page.actions>
<page.navigation>
<tabs />
</page.navigation>
<page.body>
<p>content</p>
</page.body>
</Rose::Layout::Page>
The more I think about it, we can probably get away with using simple heading tags for the title <h2>
for now, until we have more design detail.
And rename the existing "page" layout to Global to align with Structure: Rose::Layout::Global
.
For now, don't worry about the link button styles. We can come back to that soon. Let's get the layouts settled. |
Main content header component contains a title(basic & dropdown) with actions.
Page header component comprises of a simple 1x1 grid component
Introduce new PageHeader layout, title, and utilities components
062a7ac
to
c4023ab
Compare
Updates: <Rose::Layout::Global as |global|>
<global.header />
<global.navigation />
<global.body />
</Rose::Layout::Global> Page layout is to be placed into <Rose::Layout::Page as |page|>
<page.breadcrumbs />
<page.header />
<page.actions />
<page.navigation />
<page.body />
</Rose::Layout::Page>
|
@randallmorey , regarding minimizing layout sass files, in one of our previous discussions/PRs, you voiced interest in expanding sass files to replicate associated style used in templates. Should I not be following this pattern anymore? I'm always happy with less files to search through. |
The layout regions are all essentially identical. I created a ticket to consolidate these. Going forward it doesn't seem worthwhile to split them into their own files. |
…6f56f6d42f5bea0f31d0786a [main] OSS to ENT merge of (0cecb0d)
Main content header component contains a title(basic & dropdown) with
actions. Title dropdown is styled
Rose::Header::Dropdown
component whereas header actions are simpleRose::Button
components.