Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splattribute merging of "class" attribute fails #17533

Closed
wants to merge 1 commit into from
Closed

Splattribute merging of "class" attribute fails #17533

wants to merge 1 commit into from

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Jan 30, 2019

When a class= attribute comes after ...attributes, we don't merge it correctly. Instead it gets clobbered.

This PR adds failing tests. The new tests are based on existing tests, but with the order of the attributes reversed.

@ef4
Splattribute merging of "class" attribute fails
8e124d5 
When a `class=` attribute comes _after_ `...attributes`, we don't merge it correctly. Instead it gets clobbered.

This PR adds failing tests.
@ef4 ef4 mentioned this pull request Jan 31, 2019
Merged
@rwjblue rwjblue mentioned this pull request Mar 2, 2019
Closed
@GavinJoyce GavinJoyce mentioned this pull request Mar 2, 2019
Closed
wycats pushed a commit to glimmerjs/glimmer-vm that referenced this pull request Apr 3, 2019
@chancancode
Fix ...attributes (emberjs/ember.js#17533)
6903999
@chancancode chancancode mentioned this pull request Apr 3, 2019
Merged
wycats pushed a commit to glimmerjs/glimmer-vm that referenced this pull request Apr 3, 2019
@chancancode
Fix ...attributes (emberjs/ember.js#17533)
e106311
chancancode added a commit to glimmerjs/glimmer-vm that referenced this pull request Apr 3, 2019
@chancancode
Fix ...attributes (emberjs/ember.js#17533)
1511f15
chancancode added a commit to glimmerjs/glimmer-vm that referenced this pull request Apr 3, 2019
@chancancode
Fix ...attributes (emberjs/ember.js#17533)
6fcb5f7
chancancode added a commit to glimmerjs/glimmer-vm that referenced this pull request Apr 3, 2019
@chancancode
Fix ...attributes (emberjs/ember.js#17533)
8cb1c68
@chancancode chancancode mentioned this pull request Apr 6, 2019
Merged
2 tasks
wycats pushed a commit that referenced this pull request Apr 6, 2019
@chancancode
[BUGFIX canary] Fix "splattributes" class merging
388a831 
(beta will need a different version)

Closes #17533, #17692.
wycats pushed a commit that referenced this pull request Apr 6, 2019
@chancancode
[BUGFIX beta] Fix "splattributes" class merging
0274a78 
Closes #17533, #17692.

(cherry picked from commit 388a831)
wycats pushed a commit that referenced this pull request Apr 6, 2019
@chancancode
[BUGFIX canary] Fix "splattributes" class merging
2a96c78 
(beta will need a different version)

Closes #17533, #17692.
wycats pushed a commit that referenced this pull request Apr 6, 2019
@chancancode
[BUGFIX beta] Fix "splattributes" class merging
61c1830 
Closes #17533, #17692.

(cherry picked from commit 2a96c78)
@chancancode chancancode deleted the splattribute-merge-bug branch April 6, 2019 03:07
wycats pushed a commit that referenced this pull request Apr 9, 2019
@chancancode
[BUGFIX beta] Fix "splattributes" class merging
9173312 
Closes #17533, #17692.

(cherry picked from commit 2a96c78)
(cherry picked from commit 61c1830)
@rwjblue rwjblue mentioned this pull request Apr 10, 2019
Open
@gsusmi gsusmi mentioned this pull request Jun 2, 2020
Merged
@elwayman02 elwayman02 mentioned this pull request Jun 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ef4