Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more fields for csv #930

Merged
merged 3 commits into from
Sep 28, 2024
Merged

feat: add more fields for csv #930

merged 3 commits into from
Sep 28, 2024

Conversation

Sheng-Long
Copy link
Contributor

@Sheng-Long Sheng-Long commented Sep 18, 2024

Signed-off-by: Tim Schmidt [email protected]

Description:
Add CSV fields

Related issue(s):

Fixes #884

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

codecov bot commented Sep 18, 2024

The author of this PR, Sheng-Long, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at [email protected] with any questions.

@Sheng-Long Sheng-Long force-pushed the addCSVFields branch 2 times, most recently from 78def84 to 193748b Compare September 18, 2024 15:27
@SvetBorislavov
Copy link
Contributor

@Sheng-Long Once I import the demoExample2.csv, I receive the following error in the console:

Screenshot 2024-09-25 at 10 59 23

@SvetBorislavov SvetBorislavov force-pushed the addCSVFields branch 2 times, most recently from 2127c10 to a7b7a93 Compare September 25, 2024 15:58
@Sheng-Long
Copy link
Contributor Author

Should be fixed ^

@SvetBorislavov SvetBorislavov merged commit 5e2435e into main Sep 28, 2024
12 checks passed
@SvetBorislavov SvetBorislavov deleted the addCSVFields branch September 28, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the CSV import to take in a some extra fields
3 participants