Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the CSV import to take in a some extra fields #884

Closed
SimiHunjan opened this issue Sep 5, 2024 · 2 comments · Fixed by #930
Closed

Update the CSV import to take in a some extra fields #884

SimiHunjan opened this issue Sep 5, 2024 · 2 comments · Fixed by #930
Assignees
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P1 High priority issue. Required to be completed in the assigned milestone.
Milestone

Comments

@SimiHunjan
Copy link
Contributor

Problem

Include the addition fields to read from the CSV:

  • Transaction fee
  • Transaction valid duration
    Screenshot 2024-09-05 at 4 32 11 PM

Solution

if there is no transaction fee payer ID populated, use the sender account ID
If there is a transaction fee payer ID populated, use that as the transaction fee payer
If there is a transaction fee, use that as the max transaction fee value
If there is no transaction fee, use the default max transaction fee value

Alternatives

No response

@SimiHunjan SimiHunjan added the Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Sep 5, 2024
@SimiHunjan
Copy link
Contributor Author

demoExample2.csv

@SimiHunjan SimiHunjan changed the title Update the CSV import to take in a some extra fields. Update the CSV import to take in a some extra fields Sep 6, 2024
@SimiHunjan SimiHunjan added the P1 High priority issue. Required to be completed in the assigned milestone. label Sep 6, 2024
@SimiHunjan SimiHunjan added this to the v0.3.8 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. P1 High priority issue. Required to be completed in the assigned milestone.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants