Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: debug_traceTransaction throws 500 for non-existing transaction hashes #2915

Conversation

victor-yanev
Copy link
Contributor

Description:

Related issue(s):

Fixes #2897

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@victor-yanev victor-yanev added the bug Something isn't working label Aug 30, 2024
@victor-yanev victor-yanev added this to the 0.55.0 milestone Aug 30, 2024
@victor-yanev victor-yanev self-assigned this Aug 30, 2024
Copy link

github-actions bot commented Aug 30, 2024

Acceptance Tests

  21 files  288 suites   29m 46s ⏱️
600 tests 565 ✔️ 4 💤 31
955 runs  918 ✔️ 6 💤 31

Results for commit e03c95e.

♻️ This comment has been updated with latest results.

@victor-yanev victor-yanev requested a review from Nana-EC as a code owner August 30, 2024 14:03
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Tests

       3 files     261 suites   19s ⏱️
1 232 tests 1 231 ✔️ 1 💤 0
1 244 runs  1 243 ✔️ 1 💤 0

Results for commit e03c95e.

@victor-yanev victor-yanev merged commit 5018b23 into main Sep 2, 2024
44 of 45 checks passed
@victor-yanev victor-yanev deleted the 2897-debug_traceTransaction-throws-500-for-non-exising-tx-hashes branch September 2, 2024 09:59
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.44%. Comparing base (b03ed7a) to head (e03c95e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2915      +/-   ##
==========================================
- Coverage   83.48%   83.44%   -0.05%     
==========================================
  Files          55       55              
  Lines        3676     3685       +9     
  Branches      765      770       +5     
==========================================
+ Hits         3069     3075       +6     
- Misses        367      368       +1     
- Partials      240      242       +2     
Flag Coverage Δ
relay 83.30% <100.00%> (-0.06%) ⬇️
server 83.05% <ø> (ø)
ws-server 97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/relay/src/lib/clients/mirrorNodeClient.ts 87.82% <ø> (ø)
...kages/relay/src/lib/services/debugService/index.ts 76.47% <100.00%> (+0.71%) ⬆️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debug_traceTransaction throws internal server error 500 for non-exising tx hashes
3 participants