-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: debug_traceTransaction
throws 500 for non-existing transaction hashes
#2915
fix: debug_traceTransaction
throws 500 for non-existing transaction hashes
#2915
Conversation
…n-exising tx hashes Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2915 +/- ##
==========================================
- Coverage 83.48% 83.44% -0.05%
==========================================
Files 55 55
Lines 3676 3685 +9
Branches 765 770 +5
==========================================
+ Hits 3069 3075 +6
- Misses 367 368 +1
- Partials 240 242 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description:
Related issue(s):
Fixes #2897
Notes for reviewer:
Checklist