Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create third batch of conformity tests #2912

Merged
merged 9 commits into from
Sep 4, 2024

Conversation

natanasow
Copy link
Collaborator

@natanasow natanasow commented Aug 30, 2024

Description:

Create tests similar to the ones in this repo for the following endpoints

  • - eth_submitWork
  • - net_listening
  • - net_version
  • - web3_clientVersion
  • - eth_subscribe
  • - eth_unsubscribe
  • - debug_traceTransaction
  • - eth_newFilter

Covered in batch two:

  • ❌ - eth_uninstallFilter
  • ❌ - eth_getFilterChanges
  • ❌ - eth_getFilterLogs

Related issue(s):

Fixes #2727

Depends on:
#2915

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: nikolay <[email protected]>
@natanasow natanasow self-assigned this Aug 30, 2024
@natanasow natanasow added this to the 0.55.0 milestone Aug 30, 2024
@natanasow natanasow added the enhancement New feature or request label Aug 30, 2024
Copy link

github-actions bot commented Aug 30, 2024

Acceptance Tests

  17 files  229 suites   30m 44s ⏱️
597 tests 591 ✔️ 4 💤 2
651 runs  645 ✔️ 4 💤 2

Results for commit ff3a72f.

♻️ This comment has been updated with latest results.

Signed-off-by: nikolay <[email protected]>
Copy link

github-actions bot commented Aug 30, 2024

Tests

       3 files     265 suites   22s ⏱️
1 242 tests 1 241 ✔️ 1 💤 0
1 254 runs  1 253 ✔️ 1 💤 0

Results for commit ff3a72f.

♻️ This comment has been updated with latest results.

@natanasow natanasow marked this pull request as ready for review August 30, 2024 13:27
@natanasow natanasow requested review from AlfredoG87, ebadiere, Nana-EC and a team as code owners August 30, 2024 13:27
Copy link

sonarqubecloud bot commented Sep 3, 2024

@Ivo-Yankov Ivo-Yankov merged commit 234f8a3 into main Sep 4, 2024
47 checks passed
@Ivo-Yankov Ivo-Yankov deleted the 2727-create-third-batch-of-conformity-tests branch September 4, 2024 09:19
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.16%. Comparing base (5018b23) to head (ff3a72f).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2912   +/-   ##
=======================================
  Coverage   84.16%   84.16%           
=======================================
  Files          56       56           
  Lines        3752     3752           
  Branches      772      772           
=======================================
  Hits         3158     3158           
  Misses        355      355           
  Partials      239      239           
Flag Coverage Δ
relay 84.20% <ø> (ø)
server 83.05% <ø> (ø)
ws-server 97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create third batch of additional conformity tests
3 participants