Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable filter schedule button if all rows do not have sourceSchedule #1263

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Jan 13, 2025

Summary

Port harvester/harvester-ui-extension@d72857f to harvester/dashboard.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #
harvester/harvester#6949

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

@a110605 a110605 self-assigned this Jan 13, 2025
@a110605 a110605 changed the title chore: disable filter schedule button if all rows do not have sourceSchedule disable filter schedule button if all rows do not have sourceSchedule Jan 13, 2025
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 merged commit e6dfe0e into harvester:master Jan 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants