Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT][GUI] Disable Filter Schedule button if there is no backups/snapshots created by schedule job #6949

Closed
a110605 opened this issue Nov 5, 2024 · 6 comments
Assignees
Labels
area/ui Harvester UI backport-needed/1.4.2 kind/enhancement Issues that improve or augment existing functionality
Milestone

Comments

@a110605
Copy link

a110605 commented Nov 5, 2024

Is your enhancement related to a problem? Please describe.
Disable Schedule Filter button if there is no backups/snapshots created by schedule job.

Screenshot 2024-11-05 at 2 59 04 PM
@a110605 a110605 added kind/enhancement Issues that improve or augment existing functionality area/ui Harvester UI area/ui-extension Harvester UI extension for managed and standalone Harvester backport-needed/1.4.1 labels Nov 5, 2024
@a110605 a110605 added this to the v1.5.0 milestone Nov 5, 2024
@harvesterhci-io-github-bot
Copy link
Collaborator

added backport-needed/1.4.1 issue: #6950.

@harvesterhci-io-github-bot
Copy link
Collaborator

added backport-needed/1.4.2 issue: #7301.

@a110605
Copy link
Author

a110605 commented Jan 3, 2025

This is minor UI enhancement. Let's put in v1.4.2 release

Put back to v1.4.1 release.

@harvesterhci-io-github-bot
Copy link
Collaborator

harvesterhci-io-github-bot commented Jan 13, 2025

Pre Ready-For-Testing Checklist

  • If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
    The HEP PR is at:

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
    The PR is at:

    • Does the PR include the explanation for the fix or the feature?

    • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
      The PR for the YAML change is at:
      The PR for the chart change is at:

  • If labeled: area/ui Has the UI issue filed or ready to be merged?
    The UI issue/PR is at:

  • If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
    The documentation/KB PR is at:

  • If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

    • The automation skeleton PR is at:
    • The automation test case PR is at:
  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at:

@harvesterhci-io-github-bot
Copy link
Collaborator

Automation e2e test issue: harvester/tests#1781

@irishgordo
Copy link
Contributor

@a110605 this looks good on Version: v1.5.0-dev-20250120

It will not display the filter when there's no backups / snapshots created:

Image
Image
Image

And then when the schedules do create both backups & snapshots, the user can filter by them 😄 👍

filteringbackupsnaps.mp4

This looks good, I'll go ahead and close this out 👍

@github-project-automation github-project-automation bot moved this from New to Scheduled/Closed in Feature Request Review Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Harvester UI backport-needed/1.4.2 kind/enhancement Issues that improve or augment existing functionality
Projects
Status: Scheduled/Closed
Development

No branches or pull requests

3 participants