-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add longhorn support message in VM clone dialog #1223
Conversation
959baf7
to
d6d1bcb
Compare
@tserong @Vicente-Cheng I also disabled the VM -> |
</template> | ||
<template v-else> | ||
<Banner color="warning"> | ||
<t k="harvester.modal.cloneVM.message.support.longhorn" :raw="true" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it's fine to hard code the doc url wthin en-us.yaml in harvester/dashboard
as we will only maintain v1.4.x release in this repo.
But when we port the same change to harvester/harvester-ui-extension
. The doc link should be varaible. Like
<t k="harvester.setting.storageNetwork.tip" :raw="true" :url="storageNetworkExampleLink" /> |
I'm not sure about this, for two reasons:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Francesco Torchia <[email protected]>
Signed-off-by: Francesco Torchia <[email protected]>
Signed-off-by: Francesco Torchia <[email protected]>
Signed-off-by: Francesco Torchia <[email protected]>
Co-authored-by: Andy Lee <[email protected]>
3a40a8e
to
1f1d421
Compare
@mergify backport release-harvester-v1.4 |
✅ Backports have been created
|
…v1.4/pr-1223 Add longhorn support message in VM clone dialog (backport #1223)
Summary
PR Checklist
Related Issue harvester/harvester#6989
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video