Add longhorn support message in Volumes Export,Snapshot,Clone dialogs

Signed-off-by: Francesco Torchia <[email protected]>
harvester · Nov 14, 2024 · d6d1bcb · d6d1bcb
1 parent bea1b35
commit d6d1bcb
Show file tree

Hide file tree

Showing 5 changed files with 62 additions and 46 deletions.
diff --git a/pkg/harvester/dialog/HarvesterExportImageDialog.vue b/pkg/harvester/dialog/HarvesterExportImageDialog.vue
@@ -141,27 +141,34 @@ export default {
     </template>
 
     <template #body>
-      <LabeledSelect
-        v-model="namespace"
-        :label="t('harvester.modal.exportImage.namespace')"
-        :options="namespaces"
-        class="mb-20"
-        required
-      />
-
-      <LabeledInput
-        v-model="name"
-        :label="t('harvester.modal.exportImage.name')"
-        required
-      />
-
-      <LabeledSelect
-        v-model="storageClassName"
-        :options="storageClassOptions"
-        :label="t('harvester.storage.storageClass.label')"
-        class="mt-20"
-        required
-      />
+      <template v-if="actionResource?.isLonghornV2">
+        <Banner color="warning">
+          <t k="harvester.modal.exportImage.message.support.longhorn" :raw="true" />
+        </Banner>
+      </template>
+      <template v-else>
+        <LabeledSelect
+          v-model="namespace"
+          :label="t('harvester.modal.exportImage.namespace')"
+          :options="namespaces"
+          class="mb-20"
+          required
+        />
+
+        <LabeledInput
+          v-model="name"
+          :label="t('harvester.modal.exportImage.name')"
+          required
+        />
+
+        <LabeledSelect
+          v-model="storageClassName"
+          :options="storageClassOptions"
+          :label="t('harvester.storage.storageClass.label')"
+          class="mt-20"
+          required
+        />
+      </template>
     </template>
 
     <div slot="actions" class="actions">
@@ -171,6 +178,7 @@ export default {
         </button>
 
         <AsyncButton
+          v-if="!actionResource?.isLonghornV2"
           mode="create"
           :disabled="disableSave"
           @click="save"

diff --git a/pkg/harvester/dialog/SnapshotDialog.vue b/pkg/harvester/dialog/SnapshotDialog.vue
@@ -70,7 +70,10 @@ export default {
       {{ t('harvester.modal.snapshot.title') }}
     </template>
     <template #body>
-      <LabeledInput
+      <Banner v-if="actionResource?.isLonghornV2" color="warning">
+        <t k="harvester.modal.snapshot.message.support.longhorn" :raw="true" />
+      </Banner>
+      <LabeledInput v-else
         v-model="name"
         :label="t('harvester.modal.snapshot.name')"
         required
@@ -82,6 +85,7 @@ export default {
           {{ t('generic.cancel') }}
         </button>
         <AsyncButton
+          v-if="!actionResource?.isLonghornV2"
           mode="create"
           :disabled="disableSave"
           @click="save"

diff --git a/pkg/harvester/dialog/VolumeCloneDialog.vue b/pkg/harvester/dialog/VolumeCloneDialog.vue
@@ -81,22 +81,30 @@ export default {
       {{ t('harvester.modal.volumeClone.title') }}
     </template>
     <template #body>
-      <Checkbox v-model="cloneData" class="mb-10" label-key="harvester.modal.cloneVM.type" />
+      <template v-if="!actionResource?.isLonghornV2">
+        <Checkbox v-model="cloneData" class="mb-10" label-key="harvester.modal.cloneVM.type" />
 
-      <LabeledInput
-        v-show="cloneData"
-        v-model="name"
-        class="mb-20"
-        :label="t('harvester.modal.volumeClone.name')"
-        required
-      />
+        <LabeledInput
+          v-show="cloneData"
+          v-model="name"
+          class="mb-20"
+          :label="t('harvester.modal.volumeClone.name')"
+          required
+        />
+      </template>
+      <template v-else>
+        <Banner color="warning">
+          <t k="harvester.modal.volumeClone.message.support.longhorn" :raw="true" />
+        </Banner>
+      </template>
     </template>
     <div slot="actions" class="actions">
       <div class="buttons">
         <button class="btn role-secondary mr-10" @click="close">
           {{ t('generic.cancel') }}
         </button>
         <AsyncButton
+          v-if="!actionResource?.isLonghornV2"
           mode="create"
           :disabled="disableSave"
           @click="save"

diff --git a/pkg/harvester/l10n/en-us.yaml b/pkg/harvester/l10n/en-us.yaml
@@ -82,6 +82,8 @@ harvester:
       namespace: Namespace
       message:
         success: 'Image { name } created successfully.'
+        support:
+          longhorn: The volume uses Longhorn V2 engine, which does not <a href="https://docs.harvesterhci.io/v1.4/advanced/longhorn-v2/#limitations" target="_blank">support</a> the Export Image action.
     migration:
       failedMessage: Latest migration failed!
       title: Migration
@@ -110,11 +112,16 @@ harvester:
       name: Name
       message:
         success: 'Take Snapshot { name } successfully.'
+        support:
+          longhorn: The volume uses Longhorn V2 engine, which does not <a href="https://docs.harvesterhci.io/v1.4/advanced/longhorn-v2/#limitations" target="_blank">support</a> the Take Snapshot action.
+
     volumeClone:
       title: Clone Volume
       name: Name
       message:
         success: 'New Volume { name } cloned successfully.'
+        support:
+          longhorn: The volume uses Longhorn V2 engine, which does not <a href="https://docs.harvesterhci.io/v1.4/advanced/longhorn-v2/#limitations" target="_blank">support</a> the clone action.
     restoreSnapshot:
       title: Restore Snapshot
       name: 'New Volume Name'

diff --git a/pkg/harvester/models/harvester/persistentvolumeclaim.js b/pkg/harvester/models/harvester/persistentvolumeclaim.js
@@ -37,19 +37,13 @@ export default class HciPv extends HarvesterResource {
   get availableActions() {
     let out = super._availableActions;
 
-    // Longhorn V2 provisioner do not support volume clone feature yet
-    if (this.isLonghornV2) {
-      out = out.filter(action => action.action !== 'goToClone');
-    } else {
-      const clone = out.find(action => action.action === 'goToClone');
+    const clone = out.find(action => action.action === 'goToClone');
 
-      if (clone) {
-        clone.action = 'goToCloneVolume';
-      }
+    if (clone) {
+      clone.action = 'goToCloneVolume';
     }
 
-    if (!this.isLonghorn || !this.isLonghornV2) {
-      out = [
+    return [
         {
           action:  'exportImage',
           enabled: this.hasAction('export') && !this.isEncrypted,
@@ -62,12 +56,7 @@ export default class HciPv extends HarvesterResource {
           icon:    'icon icon-backup',
           label:   this.t('harvester.action.snapshot'),
         },
-        ...out
-      ];
-    }
-
-    return [
-      {
+              {
         action:  'cancelExpand',
         enabled: this.hasAction('cancelExpand'),
         icon:    'icon icon-backup',