Add Clippy lints to CI #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate into_owned() because methods named "into_owned" usually take self by value, not by reference. This method takes it by reference, so the method should be named "to_owned" instead. https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
hannobraun
approved these changes
Aug 12, 2022
This was referenced Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181
I also made an API deprecation, since Clippy was complaining about
Event.into_owned()taking&selfwhich is unexpected.into_owned()methods usually takeselfby value, not by reference. See https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_conventionResolution was to deprecate
into_owned()and add the properly named method,to_owned().This change may be relevant to #178