Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using cargo clippy in test workflows #181

Closed
i509VCB opened this issue Sep 8, 2021 · 1 comment · Fixed by #196
Closed

Consider using cargo clippy in test workflows #181

i509VCB opened this issue Sep 8, 2021 · 1 comment · Fixed by #196

Comments

@i509VCB
Copy link
Contributor

i509VCB commented Sep 8, 2021

Clippy adds quite a few interesting lints that may be useful to have.

At the moment running clippy has 4 errors, mostly redundant field names in initialization. Clippy does also handle things such as warning you about unnecessary clones, redundant borrows on an already borrowed field, etc.

@hannobraun
Copy link
Owner

Thank you for opening this issue, @i509VCB. I'm all for that! It's just an issue of someone doing the work, i.e. adding Clippy to the CI build and fixing the existing warnings.

Pull requests welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants