Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(externalnetwork): vpn attachment lookup #34

Merged
merged 1 commit into from
May 28, 2020

Conversation

roleyfoley
Copy link
Contributor

Description

Adds a lookup for the TransitGateway attachment when using a VPN connection.
Required for: hamlet-io/engine-plugin-aws#48

Motivation and Context

The VPNConnection Cloudformation resource is used to attach to a TransitGateway, as a result of this the Transit Gateway attachment Id isn't available from Cloudformation. The attachment Id is required for routing configuration and propogation config

This is covered as a request to the CFN team in aws-cloudformation/cloudformation-coverage-roadmap#308

How Has This Been Tested?

Tested locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves the structure or operation of the implementation)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Followup Actions

  • None

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • None of the above.

@ml019 ml019 merged commit d535a1d into master May 28, 2020
@roleyfoley roleyfoley deleted the externalnetwork-component branch May 28, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants