Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(externalnetwork): vpn support for external networks #48

Merged
merged 4 commits into from
May 28, 2020

Conversation

roleyfoley
Copy link
Contributor

Description

AWS implementation of hamlet-io/engine#1328
Initial external network implementation is for an external network with VPN connection to a network or router

Motivation and Context

Supports VPN based connections to AWS VPC services

How Has This Been Tested?

Tested in local deployment

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves the structure or operation of the implementation)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Followup Actions

  • None

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • None of the above.

@roleyfoley roleyfoley force-pushed the externalnetwork-component branch from 78077f2 to c2705de Compare May 28, 2020 00:40
@roleyfoley roleyfoley marked this pull request as ready for review May 28, 2020 14:51
@roleyfoley roleyfoley requested a review from a team May 28, 2020 14:52
@ml019 ml019 merged commit 6fa65ab into master May 28, 2020
@roleyfoley roleyfoley deleted the externalnetwork-component branch May 28, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants