Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] split yet another test #13169

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

danking
Copy link
Contributor

@danking danking commented Jun 9, 2023

No description provided.

Copy link
Collaborator

@patrick-schultz patrick-schultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general comment, we don't have to check in a new resource every time we want to use something in multiple tests. Pytest's fixtures are perfect for this.

For example:

@pytest.fixture(scope="module")
def range_table_2000():
    t = hl.utils.range_table(2000, 10)
    f = new_temp_file(extension='ht')
    t.write(f)
    return f

def test_indexed_read_1(self, range_table_2000):
    t1 = hl.read_table(range_table_2000, _create_row_uids=True)
    ...

@danking danking merged commit a4ca239 into hail-is:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants