has_name now always returns a single logical value #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
commented
Mar 20, 2019
| } | ||
| on_failure(has_name) <- function(call, env) { | ||
| paste0(deparse(call$x), " does not have name ", eval(call$which, env)) | ||
| out_names <- paste0("'", paste0(eval(call$which, env), collapse = "', '"), "'") | ||
| paste0(deparse(call$x), " does not have all of these name(s): ", out_names) |
There was a problem hiding this comment.
because of the possibility that call$which is a vector with length greater than 1, I had to do this paste0() stuff to avoid getting
Error in stop(assertError(attr(res, "msg"))) : bad error message
jameslamb
commented
Mar 20, 2019
| @@ -141,7 +142,7 @@ on_failure(is.date) <- function(call, env) { | |||
| #' see_if(mean %has_args% "y") | |||
| has_args <- function(f, args, exact = FALSE) { | |||
| assert_that(is.function(f)) | |||
|
|
|||
There was a problem hiding this comment.
Sorry, I have my RStudio set to trim trailing whitespace when I save a file. Let me know if you'd like me to revert all of these
jameslamb
commented
Mar 20, 2019
| @@ -6,3 +6,11 @@ test_that("assert_that handles long false assertions gracefully", { | |||
| "^isTRUE\\(.* [.]{3} is not TRUE$" | |||
| ) | |||
| }) | |||
|
|
|||
| test_that("assert_that handles has_name failures with multiple missing names", { | |||
There was a problem hiding this comment.
added this test to catch the condition I mentioned above, where failures with a call$which that has length > 1 could produce a bad error message
|
Thanks! |
jameslamb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #59 . In #46 I made
has_name()throw an error if you tried to check multiple names in one call, e.g.Four packages on CRAN have code (covered by tests) that uses
has_name()with multiple names, and all of them do this:Instead of breaking their code, I think the spirit of #46 (all assertions return exactly one
TRUE/FALSE) can still be accomplished by using anall()insidehas_name()! That is what I've proposed in this PR.