Release assertthat 0.2.1

[hadley]

Prepare for release:

• devtools::check()
• devtools::check_win_devel()
• rhub::check_for_cran()
• revdepcheck::revdep_check(num_workers = 4)
• Polish NEWS
• Handle has_name() failures

Submit to CRAN:

• usethis::use_version()
• Update cran-comments.md
• devtools::submit_cran()
• Approve email

Wait for CRAN...

• Accepted 🎉
• usethis::use_github_release()
• usethis::use_dev_version()

[hadley]

@jameslamb the stricter checks in has_name() cause dynutils, ExpDE, MOEADr, and prioritizr to fail. Do you want to relax this check, or do you want to inform the maintainers about the problem?

[jameslamb]

@hadley thanks for running that, I'll inform the maintainers by email

[jameslamb]

@hadley actually wait, I have a (possibly better) idea. I looked at the source code of those four packages, and all of them are doing this:

all(assertthat::has_name(x, vector_of_names))

If we changed has_name() to do that internally, it would still fulfill the goal of #46 (make all assertions return a single TRUE/FALSE) while not breaking any existing code on CRAN. Would you be open to a PR that does that?

So, concretely:

x <- list(a = TRUE, b = "hello")

has_name(x, "a")
[1] TRUE

has_name(x, c("a", "b"))
[1] TRUE

has_name(x, c("a", "d"))
[1] FALSE

[hadley]

Yeah, that'd be great

[jameslamb]

created #60

[hadley]

@jameslamb CRAN checks picked up a new problem that I missed:

    > library(testthat) 
    > library(codyn)
    > test_check("codyn")
    ── 1. Failure: community_stability loads and returns correct result (@test_commu
    `stability_onerep(dat2agg, "subplot")` threw an error with unexpected message.
    Expected match: "df does not have name subplot"
    Actual message: "df does not have all of these name(s): 'subplot'"

Would you mind doing a PR to them to fix the problem?

[jameslamb]

yep no problem. Will link here when I make it

[jameslamb]

Created NCEAS/codyn#111. I was able to do it in a way that makes their tests work with both assertthat 0.2.0 and 0.2.1, so should be minimally disruptive for them.

[hadley]

Perfect, thanks!

[jameslamb]

I see this made it to CRAN. @hadley thanks for doing a release!