Add support for RPC cancellation #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: grpc-swift has support for RPC cancellation via a cancellation handler. It should be supported here as well. Modifications: - Modify the server stream handler so that it holds the cancellation handle and triggers cancellation appropriately. - Modify the server stream handling to set a cancellation handle on the appropriate stream handler. - Update tests Result: HTTP/2 server transport respects stream cancellation
gjcairo
reviewed
Oct 15, 2024
Sources/GRPCNIOTransportCore/Server/CommonHTTP2ServerTransport.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
grpc-swift has support for RPC cancellation via a cancellation handler. It should be supported here as well.
Modifications:
Result:
HTTP/2 server transport respects stream cancellation