Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E tests with TLS enabled #12

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Add E2E tests with TLS enabled #12

merged 6 commits into from
Oct 15, 2024

Conversation

gjcairo
Copy link
Collaborator

@gjcairo gjcairo commented Oct 8, 2024 •
edited
Loading

This PR adds E2E tests for NIOPosix's transport implementation with TLS enabled. It also adds some additional API to create TLS configs.

@gjcairo gjcairo added the 🆕 semver/minor Adds new public API. label Oct 8, 2024
@gjcairo gjcairo requested a review from glbrntt October 8, 2024 22:40
@gjcairo gjcairo changed the title E2e tests Add E2E tests with TLS enabled Oct 8, 2024
@gjcairo gjcairo requested review from glbrntt and removed request for glbrntt October 9, 2024 14:58
glbrntt
glbrntt requested changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, I think we can tidy up a lot of the test code though!

Sources/GRPCNIOTransportHTTP2Posix/TLSConfig.swift Show resolved Hide resolved
Sources/GRPCNIOTransportHTTP2Posix/TLSConfig.swift Outdated Show resolved Hide resolved
Tests/GRPCNIOTransportHTTP2Tests/HTTP2TransportNIOPosixTests.swift Outdated Show resolved Hide resolved
Tests/GRPCNIOTransportHTTP2Tests/HTTP2TransportTLSEnabledTests.swift Outdated Show resolved Hide resolved
Tests/GRPCNIOTransportHTTP2Tests/HTTP2TransportTLSEnabledTests.swift Outdated Show resolved Hide resolved
Tests/GRPCNIOTransportHTTP2Tests/HTTP2TransportTLSEnabledTests.swift Outdated Show resolved Hide resolved
Tests/GRPCNIOTransportHTTP2Tests/HTTP2TransportTLSEnabledTests.swift Outdated Show resolved Hide resolved
Tests/GRPCNIOTransportHTTP2Tests/HTTP2TransportTLSEnabledTests.swift Outdated Show resolved Hide resolved
Tests/GRPCNIOTransportHTTP2Tests/HTTP2TransportTLSEnabledTests.swift Outdated Show resolved Hide resolved
@gjcairo gjcairo requested a review from glbrntt October 14, 2024 14:17
glbrntt
glbrntt requested changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much easier to follow than before! I left a couple of nits but otherwise it looks great.

Tests/GRPCNIOTransportHTTP2Tests/HTTP2TransportTLSEnabledTests.swift Outdated Show resolved Hide resolved
Tests/GRPCNIOTransportHTTP2Tests/HTTP2TransportTLSEnabledTests.swift Outdated Show resolved Hide resolved
Tests/GRPCNIOTransportHTTP2Tests/HTTP2TransportTLSEnabledTests.swift Outdated Show resolved Hide resolved
@gjcairo gjcairo requested a review from glbrntt October 15, 2024 10:07
glbrntt
glbrntt approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI passes after #13 is merged. Thanks Gus!

@gjcairo gjcairo enabled auto-merge (squash) October 15, 2024 10:36
@gjcairo gjcairo merged commit b0d3ba0 into grpc:main Oct 15, 2024
4 of 6 checks passed
@gjcairo gjcairo deleted the e2e-tests branch October 15, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glbrntt glbrntt glbrntt approved these changes

Assignees
No one assigned
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjcairo @glbrntt