Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

groupby / elements-logic Public

Notifications You must be signed in to change notification settings
Fork 1
Star 0

Code
Issues
Pull requests 25
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

SFX-99: Add Core module with registration mechanism#5

Merged

jmbtutor merged 62 commits intomastergroupby/elements-logic:masterfrom SFX-99groupby/elements-logic:SFX-99Copy head branch name to clipboard

Jul 5, 2019

+783-1

Conversation Commits62 (62)Checks Files changed

Commits

Commits on Jul 3, 2019

Set up @sfx/core package
jmbtutor
committed
Add Core class
jmbtutor
committed
Make Core the default export of the package
jmbtutor
committed
Set up sinon-chai
jmbtutor
committed
Call plugins' register() function on registration
jmbtutor
committed
Split registration order assertion into another test
jmbtutor
committed
Add dummy checkDependencies function
jmbtutor
committed
Throw error when there are unmet dependencies
jmbtutor
committed
Return list of missing dependencies instead
jmbtutor
committed
Add more missing dependencies
jmbtutor
committed
Test positive dependency cases
jmbtutor
committed
Add TODO for documentation
jmbtutor
committed
Spell out equal in full
jmbtutor
committed
Add registerPlugins core util method
jmbtutor
committed
Add initPlugins function to core utils
jmbtutor
committed
Add readyPlugins core util function
jmbtutor
committed
Refactor getMissingDependencies() to accept plugins.

DanielMoniz-GBI
authored and
jmbtutor
committed
Rename getMissingDependencies to calculateMissingDependencies
jmbtutor
committed
Annotate the type instead of casting
jmbtutor
committed
Include the new plugins when calculating dependencies
jmbtutor
committed
Remove unnecessary type annotations
jmbtutor
committed
Add names to the plugins
jmbtutor
committed
Restore sinon's default sandbox after each test
jmbtutor
committed
Throw when dependencies are missing
jmbtutor
committed
Call lifecycle methods in Core.register
jmbtutor
committed
Document CoreUtils
jmbtutor
committed
Add test for circular dependencies
jmbtutor
committed
Fix type of depends
jmbtutor
committed
Normalize function type declarations
jmbtutor
committed
Export the plugin interfaces
jmbtutor
committed
Assert that the entrypoint exports the proper members
jmbtutor
committed
Do not allow plugins to modify the registry
jmbtutor
committed
Create interface for plugin registry
jmbtutor
committed
Allow the package to be used in a JavaScript project
jmbtutor
committed
Export Core as named instead of as default
jmbtutor
committed
Add bare @sfx/core readme
jmbtutor
committed
Document the Core module
jmbtutor
committed
Document the plugin interfaces
jmbtutor
committed
Document the Core utils module
jmbtutor
committed
Add crude instantiation documentation to README
jmbtutor
committed
Generate core bundle
jmbtutor
committed
Add description to package.json
jmbtutor
committed
Use new testing utils
jmbtutor
committed
Add changelog entry for Core
jmbtutor
committed
Run tests in subdirectories
jmbtutor
committed
Fix typo
jmbtutor
committed
Remove unnecessary initialization
jmbtutor
committed
Format module names as code
jmbtutor
committed
Rename core.plugins to core.registry
jmbtutor
committed
Remove unused imports
jmbtutor
committed
Use correct interface
jmbtutor
committed
Change wording of optional hooks to be less confusing
jmbtutor
committed
Remove duplicated line
jmbtutor
committed
Revert yarn.lock
jmbtutor
committed

Commits on Jul 4, 2019

Make explicit that plugins have been initialized in the ready phase
jmbtutor
committed
Remove superfluous empty lines
jmbtutor
committed
Change test name for clarity
jmbtutor
committed
Use different plugin values
jmbtutor
committed

Commits on Jul 5, 2019

Generate .d.ts files
jmbtutor
committed
Declare esnext entrypoint
jmbtutor
committed
Enable webpack tree shaking of the Core package
jmbtutor
committed
Add helper type to assert type equality
jmbtutor
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.