Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update to release-please@4, set add hidden type for hidden commits #1819

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

collindutter
Copy link
Member

@collindutter collindutter commented Mar 7, 2025

Describe your changes

Painfully migrated to release-please@4 with some valuable lessons learned.

Also added hidden type to solve this problem.

Issue ticket number and link

@collindutter collindutter force-pushed the fix/release-please-sections branch 5 times, most recently from d15cc4c to a1ce80e Compare March 7, 2025 20:28
@collindutter collindutter changed the base branch from release-please-test to main March 7, 2025 20:28
@collindutter collindutter force-pushed the fix/release-please-sections branch 12 times, most recently from b32abde to 50286d1 Compare March 7, 2025 20:53
@collindutter collindutter changed the title ci: update to release-please@4, set add hfix for hidden fixes ci: update to release-please@4, set add hidden type for hidden commits Mar 7, 2025
@collindutter collindutter force-pushed the fix/release-please-sections branch from 50286d1 to f114720 Compare March 7, 2025 20:56
@collindutter collindutter marked this pull request as ready for review March 7, 2025 20:56
@collindutter collindutter requested a review from a team March 7, 2025 20:56
@collindutter collindutter self-assigned this Mar 7, 2025
@collindutter collindutter added this to the 1.5 milestone Mar 7, 2025
Copy link
Member

@vachillo vachillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migrated to release-please@4 with improvements and added hidden type for better management. looks solid!

@collindutter collindutter added this pull request to the merge queue Mar 7, 2025
Merged via the queue into main with commit eed1c03 Mar 7, 2025
15 checks passed
@collindutter collindutter deleted the fix/release-please-sections branch March 7, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants