-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter scopes #1186
Labels
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Comments
@jcornaz did you ever find a good solution for this? |
No, not really. |
Don't love this solution but I introduced new hidden types,
release-please-config.json {
"versioning": "always-bump-minor",
"release-type": "python",
"changelog-sections": [
{
"type": "feat",
"section": "✨ Features",
"hidden": false
},
{
"type": "fix",
"section": "🐛 Bug Fixes",
"hidden": false
},
{
"type": "hfix",
"section": "🤫 Bug Fixes",
"hidden": true
},
{
"type": "perf",
"section": "🚀 Performance Improvements",
"hidden": false
},
{
"type": "revert",
"section": "🗑 Reverts",
"hidden": false
},
{
"type": "hrevert",
"section": "🤫 Reverts",
"hidden": true
},
{
"type": "docs",
"section": "📚 Documentation",
"hidden": true
},
{
"type": "style",
"section": "💎 Styles",
"hidden": true
},
{
"type": "chore",
"section": "♻️ Miscellaneous Chores",
"hidden": true
},
{
"type": "refactor",
"section": "📦 Code Refactoring",
"hidden": true
},
{
"type": "test",
"section": "🚨 Tests",
"hidden": true
},
{
"type": "build",
"section": "🛠 Build System",
"hidden": true
},
{
"type": "ci",
"section": "⚙️ Continuous Integration",
"hidden": true
}
],
"packages": {
".": {}
}
} |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Is your feature request related to a problem? Please describe.
Let's say I have some changes pending to be released. Then I realized there is a bug in one of the new unreleased features. So I fix it.
What should be the commit message type for that fix? It is definitely a fix, so the only commit type that makes sense is
fix
. But it's a fix of a bug that is not released, so I don't want that log to appear in the changelog (the next release will not fix that bug, because that bug didn't exist in the last release).Describe the solution you'd like
fix
type with a specialunreleased
"scope". Example:fix(unreleased): blablabla
.Note that
release-please
would not know about theunreleased
scope. That would be my own project-wide convention. I'd only tell release please to ignore some scopes.This has the advantage to be a generic solution that can be applied to other needs. For example, if my repository contains multiple parts let's say
frontend
andbackend
. I may decide to exclude thebackend
scope from the changelog because I destinate the changelog to users of the frontend.Describe alternatives you've considered
There could be a special footer, that tells what commit introduced the bug. Example:
And then release-please would automatically choose to either include it in the changelog (if it fixes an already released bug) or exclude it (if it fixes a non-released bug).
But I think it is more complex to implement/maintain and is useful to fewer use cases.
The text was updated successfully, but these errors were encountered: