Tweaking wishart fix from 729 #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Uses FillScaleTriL * Apples Chaining to first transpose input
…sses on branch, fails on master.
… test for lkj distribution.
Wishart density now works! Currently debugging issues with lkj
- Ensure wishart uses sigma_chol in scale_tril - Use tf$matmul(chol_draws, chol_draws, adjoint_b = TRUE) instaed of `tf_chol2symm(chol_draws)`
* Create + use expect_lower_tri. Delete expect_upper_tri * update snapshots to use `[1,,]` instead
…ion_cholesky_bijector (used in lkj_correlation). Previously, it didn't seem to work with unknown dimensions, but it now works with them.
…undant density unit tests
goldingn
force-pushed
the
tweaking-wishart-fix-from-729
branch
from
c98a9ed to
900ba51
Compare
This was referenced Nov 6, 2024
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.