Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to make to the Geweke test #720

Closed
njtierney opened this issue Aug 23, 2024 · 2 comments
Closed

Tweaks to make to the Geweke test #720

njtierney opened this issue Aug 23, 2024 · 2 comments
Milestone

Comments

@njtierney
Copy link
Collaborator

We run the Geweke test to check that greta recovers the correct distribution. We have run in to some issues with this, potentially related to TF1 - @goldingn notes that this might be some of the issue:

to make the Geweke test run fast enough, the code I wrote for TF1 does some open-heart surgery on greta internals:
https://github.com/greta-dev/greta/blob/master/tests/testthat/helpers.R#L686
which likely does not work any more with the new internals. I don't think the data list object is being reused each time now, so x isn't being updated. That would cause the Geweke test's Markov chain to wander off, and produce a plot just like this

@njtierney
Copy link
Collaborator Author

This would resolve #606

@njtierney njtierney moved this from Weekly Todo to Next release in {greta} CRAN 0.5.0 release Aug 27, 2024
@njtierney
Copy link
Collaborator Author

Fixed in #734

@njtierney njtierney closed this as completed by moving to Done in {greta} CRAN 0.5.0 release Nov 6, 2024
@njtierney njtierney added this to the 0.5.0 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant