Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weather icons for night #1941

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Conversation

bim9262
Copy link
Collaborator

@bim9262 bim9262 commented Sep 3, 2023

Also split off Fog/Mist from Cloudy

One thing I did consider, but didn't do was to make the weather a progression:

So this:

weather_fog = "\ue313" # nf-weather-fog
weather_fog_night = "\ue346" # nf-weather-night_fog

becomes:

weather_fog = [
    "\ue313", # nf-weather-fog
     "\ue346", # nf-weather-night_fog
]

This would also mean that there's less clutter for fonts that don't differentiate between day and night:

weather_fog = "\uf0c2" # fa-cloud
weather_fog_night = "\uf0c2" # fa-cloud

becomes:

weather_fog = "\uf0c2" # fa-cloud

Let me know what you think about that :)

Also split off Fog/Mist from Cloudy
@MaxVerevkin
Copy link
Collaborator

This would also mean that there's less clutter for fonts that don't differentiate between day and night:

Let me know what you think about that :)

Sounds nice! The only problem I can imagine is that this would make the night variants unnameable using the current ^icon_ syntax, but this applies to all progressions and after seven months no one has complained (#1720 (comment)), so...

@bim9262
Copy link
Collaborator Author

bim9262 commented Sep 3, 2023

I'm not sure why someone would want to... But if you only wanted to show the night version you could override the icon in the config

@MaxVerevkin
Copy link
Collaborator

I'm not sure why someone would want to... But if you only wanted to show the night version you could override the icon in the config

I meant if someone wanted to reference the night version from their custom block or in some other block, for some reason. But since this applies to all progressions I is not much of a concern.

Also one weird thing about using a progression to represent day/night variant is that the order is not that intuitive.

Anyway, feel free to choose the option you think is better.

@bim9262
Copy link
Collaborator Author

bim9262 commented Sep 3, 2023

Also one weird thing about using a progression to represent day/night variant is that the order is not that intuitive.

I think that's reason enough to leave it as is.

Copy link
Collaborator

@MaxVerevkin MaxVerevkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bim9262 bim9262 merged commit 14d05f9 into greshake:master Sep 3, 2023
@bim9262 bim9262 deleted the night_weather branch September 3, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants