-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow icon configs to contain lists instead of strings, remove icons such as bat_N #1720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like there's a few mismatches on the names in the icon files.
dc687ae
to
d6ba4c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On mobile
So for some blocks like sound, the cut off points for each icon were nonlinear, do we want to try keep that behavior? From what I saw now what was previously 0..20 will be 0..33 if there are 3 icons in the list |
I'm okay either way. To restore previous behavior we can change |
cpu_low = "\uf624" # fa-gauge (fa-gauge-{min,max} are not free) | ||
cpu_med = "\uf624" # fa-gauge | ||
cpu_high = "\uf624" # fa-gauge | ||
cpu = "\uf624" # fa-gauge (fa-gauge-{min,max} are not free) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might consider making this:
cpu = [ # fa-gauge-{min,max} are not free
"\uf624", # fa-gauge
"\uf624", # fa-gauge
"\uf625", # fa-gauge-high
]
That way the gauge will go high at 66% which looks appropriate for the icon fa-gauge-high
This way allows the user more customisation but could be a bit confusing - guess it could be OK as long as we document it or add comment in the icon config file |
d6ba4c1
to
98af638
Compare
It took me seven months to realize that the current |
This is a breaking change but it will make adding "animated" icons a non-breaking change in the future.