Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow icon configs to contain lists instead of strings, remove icons such as bat_N #1720

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

MaxVerevkin
Copy link
Collaborator

This is a breaking change but it will make adding "animated" icons a non-breaking change in the future.

@MaxVerevkin MaxVerevkin added configuration Changes to or issues with configuration files themes/icons breaking Breaking changes labels Feb 9, 2023
@MaxVerevkin MaxVerevkin requested a review from ammgws February 9, 2023 20:42
Copy link
Collaborator

@bim9262 bim9262 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like there's a few mismatches on the names in the icon files.

@bim9262 bim9262 mentioned this pull request Feb 11, 2023
@MaxVerevkin MaxVerevkin force-pushed the simplify-animated-icons branch from dc687ae to d6ba4c1 Compare February 11, 2023 09:57
Copy link
Collaborator

@ammgws ammgws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mobile

@ammgws
Copy link
Collaborator

ammgws commented Feb 16, 2023

So for some blocks like sound, the cut off points for each icon were nonlinear, do we want to try keep that behavior? From what I saw now what was previously 0..20 will be 0..33 if there are 3 icons in the list

@MaxVerevkin
Copy link
Collaborator Author

So for some blocks like sound, the cut off points for each icon were nonlinear, do we want to try keep that behavior? From what I saw now what was previously 0..20 will be 0..33 if there are 3 icons in the list

I'm okay either way. To restore previous behavior we can change [a,b,c] to [a,b,b,b,c].

cpu_low = "\uf624" # fa-gauge (fa-gauge-{min,max} are not free)
cpu_med = "\uf624" # fa-gauge
cpu_high = "\uf624" # fa-gauge
cpu = "\uf624" # fa-gauge (fa-gauge-{min,max} are not free)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might consider making this:

cpu = [ # fa-gauge-{min,max} are not free
    "\uf624", # fa-gauge
    "\uf624", # fa-gauge
    "\uf625", # fa-gauge-high
]

That way the gauge will go high at 66% which looks appropriate for the icon fa-gauge-high

@ammgws
Copy link
Collaborator

ammgws commented Feb 17, 2023

I'm okay either way. To restore previous behavior we can change [a,b,c] to [a,b,b,b,c].

This way allows the user more customisation but could be a bit confusing - guess it could be OK as long as we document it or add comment in the icon config file

@MaxVerevkin MaxVerevkin force-pushed the simplify-animated-icons branch from d6ba4c1 to 98af638 Compare February 17, 2023 07:43
@ammgws ammgws merged commit ca17a49 into master Feb 18, 2023
@ammgws ammgws deleted the simplify-animated-icons branch February 18, 2023 06:57
@MaxVerevkin
Copy link
Collaborator Author

It took me seven months to realize that the current ^icon_ syntax does not support specifying an icon from that progression...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes configuration Changes to or issues with configuration files themes/icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants