Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referee 1.2 #684

Closed
cgreene opened this issue Nov 3, 2017 · 9 comments
Closed

Referee 1.2 #684

cgreene opened this issue Nov 3, 2017 · 9 comments

Comments

@cgreene
Copy link
Member

cgreene commented Nov 3, 2017

The authors discussed deep learning models such as sDA, CNN, RNN etc. It would be better to have a figure illustrating their architectures. This way, the reader will have a concrete visualization that will aid the understanding of the discussion points in the manuscript.

@cgreene cgreene mentioned this issue Nov 3, 2017
17 tasks
@agitter
Copy link
Collaborator

agitter commented Nov 9, 2017

Related to #354 #566 #630

@agitter agitter added this to the journal-revisions milestone Nov 17, 2017
@cgreene
Copy link
Member Author

cgreene commented Jan 10, 2018

I am starting to work on this. I've tried to get a relatively modestly sized figure that covers the main architectures that we discuss in the text.

Here's a first pass at something that covers a few of the architectures from @SiminaB's glossary.
nn-petting-zoo

This is in a google draw page, as @evancofer suggested:
https://docs.google.com/drawings/d/1TEzlqiCewmJ-EITvogMqDz7N6CizMtBvWE4H_BXqnuQ/edit

Currently it is marked world editable.

@cgreene
Copy link
Member Author

cgreene commented Jan 10, 2018

BTW these schematics are heavily derived from http://www.asimovinstitute.org/neural-network-zoo/ so we definitely should discuss Fjodor in the legend. That's why I called it the "petting zoo" in the google draw title.

@cgreene
Copy link
Member Author

cgreene commented Jan 10, 2018

Oh, wait, my deep RNN is broken 😜 . Too focused on making the recurrent bits and i missed the output layer!

@SiminaB
Copy link
Contributor

SiminaB commented Jan 11, 2018

I added edges to the legend as well - can remove or edit as desired (eg can have description of edges in legend)!

@SiminaB
Copy link
Contributor

SiminaB commented Jan 11, 2018

I'm wondering if we can add something to the figure about which types of networks are more used for supervised learning vs unsupervised learning. For example, if the outer layer matches the input layer, I guess that's always used for dimension reduction, so it would be unsupervised learning (although the reduced dimensions could then be used for supervised learning if there is an outcome). I don't have enough expertise to add this, but I think it would really help to clarify things for folks coming from stats (like myself).

@cgreene cgreene mentioned this issue Jan 12, 2018
@cgreene
Copy link
Member Author

cgreene commented Jan 13, 2018

Here's an updated version of the figure.
nn-petting-zoo 1

@cgreene
Copy link
Member Author

cgreene commented Jan 16, 2018

Updating the figure so that I can link it in the new version of PR #775.
nn-petting-zoo 2

Named in https://docs.google.com/drawings/d/1TEzlqiCewmJ-EITvogMqDz7N6CizMtBvWE4H_BXqnuQ/edit as "proposed-release"

agitter pushed a commit that referenced this issue Jan 16, 2018
* draft to address #684

* revise a bit earlier to work with new changes

* one sentence per line + typo fixes

* specify noun

* remove empty-feeling sentence

* remove missing comma

* add a

* complete extrication of DL

* Revise the CNN description

* note inspiration

* update CNN image based on @agitter suggestion
dhimmel pushed a commit that referenced this issue Jan 16, 2018
This build is based on
fef6e3a.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/greenelab/deep-review/builds/329523064
https://travis-ci.org/greenelab/deep-review/jobs/329523065

[ci skip]

The full commit message that triggered this build is copied below:

Discuss NN Architectures more fully + NN-Petting-Zoo Figure (#775)

* draft to address #684

* revise a bit earlier to work with new changes

* one sentence per line + typo fixes

* specify noun

* remove empty-feeling sentence

* remove missing comma

* add a

* complete extrication of DL

* Revise the CNN description

* note inspiration

* update CNN image based on @agitter suggestion
dhimmel pushed a commit that referenced this issue Jan 16, 2018
This build is based on
fef6e3a.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/greenelab/deep-review/builds/329523064
https://travis-ci.org/greenelab/deep-review/jobs/329523065

[ci skip]

The full commit message that triggered this build is copied below:

Discuss NN Architectures more fully + NN-Petting-Zoo Figure (#775)

* draft to address #684

* revise a bit earlier to work with new changes

* one sentence per line + typo fixes

* specify noun

* remove empty-feeling sentence

* remove missing comma

* add a

* complete extrication of DL

* Revise the CNN description

* note inspiration

* update CNN image based on @agitter suggestion
@agitter
Copy link
Collaborator

agitter commented Jan 19, 2018

Closed by #799

@agitter agitter closed this as completed Jan 19, 2018
dhimmel added a commit to dhimmel/deep-review that referenced this issue Sep 5, 2019
link to source google drawing, which was previousely difficult to
track down.

Refs greenelab#684 (comment)
dhimmel added a commit to dhimmel/deep-review that referenced this issue Sep 5, 2019
link to source google drawing, which was previousely difficult to
track down.

Refs greenelab#684 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants