Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referee 1.1 #683

Closed
cgreene opened this issue Nov 3, 2017 · 8 comments
Closed

Referee 1.1 #683

cgreene opened this issue Nov 3, 2017 · 8 comments

Comments

@cgreene
Copy link
Member

cgreene commented Nov 3, 2017

The authors summarized over 400 literature references purely by narratives. The authors provided synopsis for each important reference, but lacks synthesis of related work. It would be better to synthesize related work into a table and analyze their characteristics.

@cgreene cgreene mentioned this issue Nov 3, 2017
17 tasks
@agitter
Copy link
Collaborator

agitter commented Nov 9, 2017

Before addressing this, I'd like to confirm what the reviewer is asking for. Does "related work" mean comparing/contrasting groups of related papers that are discussed in the review? Or comparing/contrasting the neural network-based methods with other types of algorithms?

@michaelmhoffman
Copy link
Contributor

michaelmhoffman commented Nov 9, 2017 via email

@agitter agitter added this to the journal-revisions milestone Nov 17, 2017
@agitter
Copy link
Collaborator

agitter commented Jan 12, 2018

@cgreene we haven't done much to address this yet. I don't think our new table is exactly what the reviewer had in mind.

@cgreene
Copy link
Member Author

cgreene commented Jan 12, 2018

I agree. I am hoping that the text that goes along with the figure in #684 will also help with this; however, I have thought about it but not actually written it (been on my to-do list for 2 days).

@agitter
Copy link
Collaborator

agitter commented Jan 12, 2018

Would it help if we give examples of where different network architectures are commonly used? We can't be exhaustive, but we could say things like 1D CNNs are used for text, DNA/RNA/amino acid sequence, etc. Graph convolutions are used in PPI networks and molecular graphs.

@SiminaB
Copy link
Contributor

SiminaB commented Jan 13, 2018

I think that would be a good idea @agitter! In #684 I had also mentioned discussing which ones are more used for supervised vs unsupervised applications.

@SiminaB
Copy link
Contributor

SiminaB commented Jan 13, 2018

If the mapping works out, we could add another column to the table. Another option would be to make another table (or bulleted list), with something like:

Patient categorization:
Imaging: transfer learning
Text applications: CNNs
EHRs: CNNs, RNNs, LSTM
etc

or to build on this figure https://github.com/greenelab/deep-review/blob/master/content/images/biotm.pdf

cgreene added a commit to cgreene/deep-review that referenced this issue Jan 18, 2018
cgreene added a commit to cgreene/deep-review that referenced this issue Jan 18, 2018
@agitter
Copy link
Collaborator

agitter commented Jan 19, 2018

Closed by #799

@agitter agitter closed this as completed Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants